Remove caveat about combos with shared keys #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combos with shared keys are supported as of #2561. Therefore, this caveat no longer applies.
noroadsleft
approved these changes
Apr 10, 2019
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Apr 14, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (101 commits) Change table names Cleanup code Make send_char multilined for readaability Clean up some of the code Add AltGr/RALT support to Send String Add vendor and product arguments to atmega32a_program.py - fix hex print Add vendor and product arguments to atmega32a_program.py Max out range for max compatibility Fix ATSAM's USB HID descriptor to support higher heycodes Fix build detection of keymap and board changes Apply MAKEFLAGS to speed up CI Flesh out keymaps and some tweaks to indicators (qmk#5608) add in the missing #defines Update ps2avrgb readme template (qmk#5584) Use DIRECT_PINS for BDN9 (qmk#5603) Port DIRECT_PINS from split_common/matrix.c to matrix.c (qmk#5091) Keyboard: Add yosino58 Keyboard (qmk#5465) fix offset in matrix (qmk#5600) Remove caveat about combos with shared keys (qmk#5601) Revert "Update build instructions and docker file to download submodules" (qmk#5533) ...
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
Combos with shared keys are supported as of qmk#2561. Therefore, this caveat no longer applies.
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
Combos with shared keys are supported as of qmk#2561. Therefore, this caveat no longer applies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combos with shared keys are supported as of #2561. Therefore, this caveat no longer applies and should be removed.
Types of Changes
Checklist